Browser Extension Vote-Counter (early demo)
-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
i think psyche is asking how the votecounter matches vote strings to playersIn post 22, JacksonVirgo wrote:
I have absolutely no idea what you meanIn post 20, Psyche wrote: How much dev or validation do you think the vote tabulator itself might need? Can you remind of the basic strategy it implements?-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
been wanting to contribute to this project too, i'll revisit this soon!
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
gotcha, i was just wondering why u would use zod because it is kinda overkill for this project, interfaces and TSDoc that come out of the box with typescript should be good enoughIn post 105, JacksonVirgo wrote:
I used what I was most comfortable with as I wanted to spit something out pretty fast, I haven’t touched much tsdoc all things considered even though I probably should.In post 104, yessiree wrote: been wanting to contribute to this project too, i'll revisit this soon!
quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
maybe my first PR will be deprecating zod and replacing it with typescript native syntax-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation stepIn post 111, JacksonVirgo wrote:
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scriptsIn post 104, yessiree wrote: quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
this might help (i see you have a lot of optional fields in the game definition check)
https://www.typescriptlang.org/docs/han ... predicates-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
yeah on a closer look of the codebase i dont think zod is as overkill as i thought it was lolIn post 113, JacksonVirgo wrote:
Yeah I know types don't exist in runtime, that's why I am using zod to validate itIn post 112, yessiree wrote:
if you are validating objects during runtime (from user input), there is no easy way, because types don't exist in runtime, you'd have to go through the good ol' user input validation stepIn post 111, JacksonVirgo wrote:
Can TSDoc validate objects? Because I'm mostly using Zod to validate types so I don't have to go through and check them myself, as there is no typesafe layer when communicating from the content scripts and the bg scriptsIn post 104, yessiree wrote: quick question @JV, why did you decide to use a package like zod, as opposed to just regular TSDoc? zod is kind of intimidating to see in a ts project ngl
this might help (i see you have a lot of optional fields in the game definition check)
https://www.typescriptlang.org/docs/han ... predicates-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
Can ignore what I talked about
It's only about syntax so not very relevant to the actual features of the project-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
In post 119, JacksonVirgo wrote:
I recall last time the issue was using tabs and not spaces or something (which is so silly of a problem) is it that again?In post 118, Aureal wrote: This thing still hates me no matter what I do. Can't even get it working with just the player list again. I recall last time I used it I had to workaround the dead section not working by just removing those players from the list.
https://github.com/JacksonVirgo/mafiasc ... ols/pull/3In post 120, Aureal wrote: Nope, definitely using spaces. Repeatedly tried copy/pasting the both the last game's file and the formatting you gave me and just adjusting the names.
I submitted a PR to fix the issue Aureal is having. Please review and merge, thanks!-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
glad to helpIn post 122, JacksonVirgo wrote: Merged. Thanks for catching that btw lol.
Sadly I don’t have a way to compile it at the moment (my computer is deadge)
thanks to Aureal for being the guinea pig-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
submitted another PR for some refactoring
one of them is using "view=print" mode when scraping posts, which should drastically speed up votecount generation since it potentially reduces the response payload size by over 90%! (from over 1 MB to ~40 kB per request)-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
what are we cooking next? what's on your radar atm-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
something more tangible and less grandeur-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
would it really need to be a "votecount" though, as in a snapshot of all votes at a given time, since the underlying data would just be a collection of votes-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
i guess that begs the question actually: what data format would be best suited to run vca or any kind of analysis on voting behaviors-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
For votes with ambiguous targets, I lean more towards flagging them to be checked manually rather than trying to parse the intended target using NLP. Reason one is that configuration (usernames, aliases and replacements) are needed for each game anyway, reason two is that if the string parsing algo is not 100% accurate, you dataset ends up with some incorrect data, and reason three - NLP is hard!
I imagine the process would be like
- configure basic settings (usernames, replacements, common aliases, etc) for games from which to collect data
- collect votes -> get a list of votes + a list of flagged votes
- go through the flagged votes one by one and add aliases as necessary
- repeat step 2 until you have no more flagged votes-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
Well actually I was thinking of working on a config editor to replace yaml config files altogether, but wasn't sure if that's the direction you wanted to go. Basically, it will be a UI that lets you edit configs and save/load them to/from local storage.In post 152, JacksonVirgo wrote: I also want to add cached config results so you don't have to upload over and over.-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
probably because you were using jqueryIn post 167, JacksonVirgo wrote:
I wanted to do this much earlier but never got the motivation to actually get it to work so I scrapped it temporarilyIn post 166, yessiree wrote:
Well actually I was thinking of working on a config editor to replace yaml config files altogether, but wasn't sure if that's the direction you wanted to go. Basically, it will be a UI that lets you edit configs and save/load them to/from local storage.In post 152, JacksonVirgo wrote: I also want to add cached config results so you don't have to upload over and over.
should be fairly trivial with react!-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
I can work out a quick WIP next week-
-
yessiree heMafia Scumhe
- Mafia Scum
- Mafia Scum
- Posts: 4390
- Joined: June 6, 2013
- Pronoun: he
hmm, I definitely agree that the string matching algo needs to perform at a certain accuracy level, or be improved in some way, but for the average mod who's using this to generate VCs every now and then, I don't think it's too much trouble for them to go through this process of looking at flagged votes and addressing them through config fixes?
as for vca, i should clarify that i don't really see the whole process happening at once. That is, collecting data and then performing analysis on said data. In other words, I don't see that we're shipping a tool that does everything in one complete package. I moreso see it as two separate processes; first is the data collection part, with the goal of creating a dataset to be used later, the second one is the analysis. These two processes don't need to be coupled together.
so i guess what im trying to say is that i dont see the point of creating a tool for other people to collect data on their own, but rather creating a tool to collect data ourselves, and then making this dataset available to the public. in that vein, data is only collected once and done, and that reduces the need for a perfect algorithm, if that makes sense
i dont want to stop you from doing what you're doing tho!
Copyright © MafiaScum. All rights reserved.